Launch Week Day 1: Announcing Security Design Review
MEDIUM 5.9 Go

1Panel's password verification is suspected to have a timing attack vulnerability

GHSA-6m9h-2pr2-9j8f · CVE-2024-30257 · GO-2024-2734

Published · Modified

Description

Summary

源码中密码校验处使用 != 符号,而不是hmac.Equal,这可能导致产生计时攻击漏洞,从而爆破密码。
建议使用 hmac.Equal 比对密码。

Translation:

The source code uses the != symbol instead of hmac.Equal for password verification, which may lead to timing attack vulnerabilities that can lead to password cracking. It is recommended to use hmac. Equal to compare passwords.

Details

https://github.com/1Panel-dev/1Panel/blob/dev/backend/app/service/auth.go#L81C5-L81C26

Impact

该产品的所有使用者。

Translation:

All users of this product.

Ready to move

Start Securing

Free, no credit card | First findings in minutes