Launch Week Day 1: Announcing Security Design Review
HIGH 7.5 PyPI

Vyper vulnerable to incorrect ordering of arguments for kwargs passed to internal calls

GHSA-ph9x-4vc9-m39g · CVE-2023-32059 · PYSEC-2023-79

Published · Modified

Description

Impact

Internal calls to internal functions with more than 1 default argument are compiled incorrectly. Depending on the number of arguments
provided in the call, the defaults are added not right-to-left, but left-to-right. If the types are incompatible,
typechecking is bypassed. In the bar() function in the following code, self.foo(13) is compiled to
self.foo(13,12) instead of self.foo(13,1337).

@internal
def foo(a:uint256 = 12, b:uint256 = 1337):
    pass

@internal
def bar():
    self.foo(13)

note that at the time of publication, the ability to pass kwargs to internal functions is an undocumented feature that does not seem to be widely used.

Patches

patched in c3e68c302aa6e1429946473769dd1232145822ac

Workarounds

Is there a way for users to fix or remediate the vulnerability without upgrading?

References

Are there any links users can visit to find out more?

Ready to move

Start Securing

Free, no credit card | First findings in minutes