incorrect order of evaluation of side effects for some builtins
GHSA-4hg4-9mf5-wxxq · CVE-2023-41052 · PYSEC-2023-168
Published · Modified
AI SAST
Find this class of vulnerability in your own code
Corgea's AI-native static analysis detects vulnerabilities like this one across your repositories, ranks them by exploitability, and returns review-ready fixes.
Description
Impact
The order of evaluation of the arguments of the builtin functions uint256_addmod, uint256_mulmod, ecadd and ecmul does not follow source order.
• For uint256_addmod(a,b,c) and uint256_mulmod(a,b,c), the order is c,a,b.
• For ecadd(a,b) and ecmul(a,b), the order is b,a.
Note that this behaviour is problematic when the evaluation of one of the arguments produces side effects that other arguments depend on.
Patches
https://github.com/vyperlang/vyper/pull/3583
Workarounds
When using builtins from the list above, make sure that the arguments of the expression do not produce side effects or, if one does, that no other argument is dependent on those side effects.
References
- WEB https://github.com/vyperlang/vyper/security/advisories/GHSA-4hg4-9mf5-wxxq
- ADVISORY https://nvd.nist.gov/vuln/detail/CVE-2023-41052
- WEB https://github.com/vyperlang/vyper/pull/3583
- WEB https://github.com/vyperlang/vyper/commit/78fa8dd8f91ba0cb26277eeffb585c68c83e7daa
- WEB https://github.com/pypa/advisory-database/tree/main/vulns/vyper/PYSEC-2023-168.yaml
- PACKAGE https://github.com/vyperlang/vyper
Ready to move
Start Securing
Free, no credit card | First findings in minutes