Mareforma: invalidated claims still promote to REPLICATED
GHSA-rgg9-956j-3378 · CVE-2026-71500
Published · Modified
AI SAST
Find this class of vulnerability in your own code
Corgea's AI-native static analysis detects vulnerabilities like this one across your repositories, ranks them by exploitability, and returns review-ready fixes.
Description
What's wrong
_maybe_update_replicated_unlocked never checks t_invalid, so a claim that a signed contradiction verdict has marked invalid can still climb to REPLICATED through convergence detection, and it pulls an honest peer up with it.
Three gaps line up:
- The new-claim short-circuit reads only
statusandasserter_keyid(core.py:1339-1352); an invalidated but still-opennew claim passes. - The candidate-peer SELECT filters
status = 'open',unresolved = 0, andtransparency_logged = 1but has not_invalidpredicate (core.py:1390-1410), so an invalidated existing claim qualifies as a convergence partner. - The promotion UPDATE gates only on
status = 'open'(core.py:1422-1426), leaving a TOCTOU window even after the SELECT is fixed.
A signed contradiction verdict is meant to be terminal for the trust ladder: validate_claim refuses to promote a t_invalid claim to ESTABLISHED, and record_replication_verdict already gates its promotion UPDATE on t_invalid IS NULL. Convergence promotion is the one path that ignores the verdict. Reproduced at runtime: contradict claim X (t_invalid set, still PRELIMINARY), then assert peer Y sharing X's ESTABLISHED anchor; both X and Y land at REPLICATED, with X's t_invalid still set.
Severity and impact
High. A refuted claim re-enters the trust ladder at REPLICATED after its contradiction, and it serves as the corroborating peer that promotes an honest claim. Both outcomes contradict the documented refutation model, and REPLICATED is the input to further validation.
Location
mareforma/db/core.py:1339new-claim short-circuit checksstatusandasserter_keyidbut nott_invalidmareforma/db/core.py:1390candidate-peer SELECT WHERE clause has not_invalid IS NULLpredicatemareforma/db/core.py:1422promotion UPDATE gates onstatus = 'open'only, reopening the window between SELECT and UPDATE
Fix direction
Treat t_invalid the way the neighboring code already does. Extend the new-claim short-circuit to also read t_invalid and return when it is set. Add AND c.t_invalid IS NULL to the candidate-peer SELECT. Add AND t_invalid IS NULL to the promotion UPDATE's WHERE clause so the row-level lock closes the TOCTOU window, matching the gate record_replication_verdict already applies at core.py:3539.
Do red/green TDD: add a regression test that fails on main, then make it pass.
Quality bar
SOLID, DRY, KISS. Clean, readable, well-tested code. No new errors, warnings, or test failures; the full suite stays green on all supported Python versions.
References
- WEB https://github.com/mareforma/mareforma/security/advisories/GHSA-rgg9-956j-3378
- ADVISORY https://nvd.nist.gov/vuln/detail/CVE-2026-71500
- WEB https://github.com/mareforma/mareforma/pull/58
- WEB https://github.com/mareforma/mareforma/commit/c9d8922132d916e4fd013890cb4e17921e00065e
- PACKAGE https://github.com/mareforma/mareforma
- WEB https://github.com/mareforma/mareforma/releases/tag/v0.3.8
Ready to move
Start Securing
Free, no credit card | First findings in minutes